• 5 Posts
  • 83 Comments
Joined 3 years ago
cake
Cake day: April 27th, 2024

help-circle











  • I’m about to have a convo with my team, which to be clear is a good team. It’s going to go like this:

    “If I write a comment where there has been a pattern of that same comment more than twice across your PRs in the past month (missing indexes, rewritten code for no reason, duplicate code, etc), I will immediately reject the review. If I have to do this twice for the same PR, there will be accountability. And unlike when something proves a challenge and we are flexible, timelines will not shift if one of these occur.”

    I personally think this is fair, as we rarely ever put our team into any kind of cram mode. I’m all for heavily assisted dev if it makes life easier, but it should not fall on the seniors to catch the obvious issues.